Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling underscores in GCS bucket name #6998

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Fix handling underscores in GCS bucket name #6998

merged 3 commits into from
Apr 21, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Apr 21, 2023 •
edited

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Explore gs://iarpa_microns/minnie/minnie65/seg (now possible)
  • Explore gs://neuroglancer-fafb-data/fafb_v14/fafb_v14_orig (still possible)

(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Needs datastore update after deployment

fm3
fm3 reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does getAuthority relate to underscores? 🤔

@frcroth
Copy link
Member Author

frcroth commented Apr 21, 2023

How does getAuthority relate to underscores? thinking

Added explanatory comment. Authority is everything until the path (so the next slash), while host has to be in (alphanumeric| dash)+.

@frcroth frcroth changed the title Fix underscore in google cloud storage url Fix handling underscores in GCS bucket name Apr 21, 2023
@frcroth frcroth requested a review from fm3 April 21, 2023 09:31
fm3
fm3 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frcroth frcroth merged commit b0f03f8 into master Apr 21, 2023
2 checks passed
@frcroth frcroth deleted the fix-gs-underscore branch April 21, 2023 10:01
hotzenklotz added a commit that referenced this pull request Apr 21, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into ema…
942e46c 
…il-images

* 'master' of github.com:scalableminds/webknossos:
  Fix handling underscores in GCS bucket name (#6998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

@fm3 fm3 fm3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frcroth @normanrz @fm3