Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access check in time tracking controller #7055

Merged
merged 1 commit into from
May 8, 2023
Merged

Fix access check in time tracking controller #7055

merged 1 commit into from
May 8, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 8, 2023

Not the full user object should be compared for the access check, that created false differences in lastActivity timestamp. (User caching recently changed slightly, but this should not be able to have effects here)

Steps to test:

  • Create non-admin user (or just use sample2@scm.io from the sample organization)
  • Log in as that user, go to time tracking page
  • No error concerning authorization should show up

@fm3 fm3 self-assigned this May 8, 2023
@fm3 fm3 marked this pull request as ready for review May 8, 2023 08:13
@fm3 fm3 requested a review from frcroth May 8, 2023 08:13
@fm3 fm3 enabled auto-merge (squash) May 8, 2023 08:19
@fm3 fm3 merged commit f919f3e into master May 8, 2023
2 checks passed
@fm3 fm3 deleted the time-user-check branch May 8, 2023 08:25
philippotto added a commit that referenced this pull request May 8, 2023
* Release 23.05.0

* Guard against NaNs in shader (#7018)

* guard against nan when deciding whether to use performance optimization in shader

* update changelog

* Workaround for WebGL crash for datasets with many segmentation layers (#6995)

* reduce shader complexity when having multiple segmentation layers (shader needs to be compiled more often then, though)

* fix tests

* clean up

* update changelog

* Release 23.05.1

* Fix access check in time tracking controller (#7055)

* Release 23.05.2

---------

Co-authored-by: Florian M <fm3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants