Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when browser doesn't support certain features #7165

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 21, 2023

I decided to do a simple smoke test instead of adding a new dependency which does fancy browser-lists comparisons. That way, the added code is very little and we can only test against features from which we know that WK needs them.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I tested that no error appears in modern browsers
  • I changed AbortController to have a typo --> toast appears

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jun 21, 2023
@philippotto philippotto merged commit a18ccd5 into master Jun 22, 2023
2 checks passed
@philippotto philippotto deleted the warn-unsupported-features branch June 22, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn user if outdated/unsupported browser is used
2 participants