Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use s3 auth environment variables if set #7170

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Use s3 auth environment variables if set #7170

merged 4 commits into from
Jun 26, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jun 22, 2023 •
edited

Reads s3 credentials from environment variables if available (whenever none are supplied via UI)

Steps to test:

  • Explore remote dataset that needs S3 credentials via the Add Remote Dataset Tab, but do not supply credentials in the UI. Should fail
  • Now restart webknossos with AWS_ACCESS_KEY_ID=<value> AWS_SECRET_KEY=<value> yarn start
  • The same should work now

Issues:

  • Updated changelog
  • Needs datastore update after deployment

@fm3 fm3 self-assigned this Jun 22, 2023
@fm3 fm3 marked this pull request as draft June 22, 2023 15:42
@fm3 fm3 marked this pull request as ready for review June 26, 2023 07:28
@fm3 fm3 changed the title WIP: Use s3 auth environment variables if set Use s3 auth environment variables if set Jun 26, 2023
@fm3 fm3 requested a review from normanrz June 26, 2023 07:29
@fm3 fm3 enabled auto-merge (squash) June 26, 2023 11:43
@fm3 fm3 merged commit 189b775 into master Jun 26, 2023
2 checks passed
@fm3 fm3 deleted the aws-env-var branch June 26, 2023 12:02
@fm3 fm3 mentioned this pull request Jul 6, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees

@fm3 fm3

Labels
backend new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support global remote dataset credentials
2 participants
@fm3 @normanrz