Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt-in webgl antialiasing #7180

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Opt-in webgl antialiasing #7180

merged 5 commits into from
Jul 18, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 30, 2023 •
edited by daniel-wer

URL of deployed dev instance (used for testing):

Steps to test:

  • open a dataset --> antialiasing should be disabled (check out diagonal lines in the 3d viewport)
  • enable the antialiasing setting in the left sidebar
  • reload the page --> antialiasing should be enabled

Issues:

  • follow-up to Prepare multi modality support #6748 which disabled antialiasing due to a rendering bug for which another workaround was adapted, too. performance-wise it makes sense to make this setting opt-in in my opinion.

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jun 30, 2023
daniel-wer
daniel-wer approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, works well 👍

frontend/javascripts/oxalis/view/left-border-tabs/controls_and_rendering_settings_tab.tsx Outdated Show resolved Hide resolved
@philippotto philippotto enabled auto-merge (squash) July 18, 2023 10:06
@philippotto philippotto merged commit 4cb730f into master Jul 18, 2023
2 checks passed
@philippotto philippotto deleted the optional-antialiasing branch July 18, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippotto @daniel-wer