-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color thumbnails with view config #7255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, looking forward to this!
- Reusing the existing Color class is fine by me
- Changing the data types of the intermediate results is also fine, as long as it does not create data loss
- Passing the invert setting would be a good follow up issue :) (I guess if you consider it to be easily done, feel free to include it here as well)
- I think there are still some overflows happening, I’m getting something like this
for a uint8 dataset (ROI2017_wkw) with color setting [200,5,5]
The frontend rendering shows this (not the exact same location, sorry, but you get the idea)
@fm3 I can't reproduce the faulty behavior. Maybe you can take another look at this? |
Looks like it does work when intensityRange is also set. 🤔 Even when it covers the full range (0,255) |
Ok, I think it was once again a weirdness of the byte type, which resulted in no intesity range being different to given full intesity range. Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely now, thanks!
Added two more small comments about naming.
Also don’t forget to enable the caching again, then this should be good to go :)
webknossos-datastore/app/com/scalableminds/webknossos/datastore/image/ImageCreator.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
URL of deployed dev instance (used for testing):
Steps to test:
Notes
Only tested with one dataset and uint16 dataTested with uint8 and unit16I used the Color class I found here and in Automatically assign color and channel name for omero ngff #7251, don't know if that class should be used.Optional TODO: Respect inverted settingDoneIssues:
(Please delete unneeded items, merge only when none are left open)