Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too tight assertions in annotation saving #7326

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 8, 2023

Fixing regression introduced in #7290

Steps to test:

  • Save skeleton with just a few clicks, should work
  • Save skeleton with imported large nml, should work
  • Save skeleton with a few clicks PLUS an import of a large nml, should work (this was the error case before)

@normanrz
Copy link
Member

normanrz commented Sep 8, 2023

So the problem was that all transactions with just 1 group would fail?

@fm3
Copy link
Member Author

fm3 commented Sep 8, 2023

So the problem was that all transactions with just 1 group would fail?

Only in requests with single-group transactions and bigger transactions

@fm3 fm3 merged commit d695791 into master Sep 8, 2023
2 checks passed
@fm3 fm3 deleted the fix-save-assertion branch September 8, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants