Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode additional coordinates in url #7328

Merged
merged 8 commits into from
Oct 12, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 11, 2023

I adapted the CSV format in the url hash so, that key=value pairs can be added to the end of the hash.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Sep 11, 2023
@philippotto philippotto changed the title [WIP] Encode additional coordinates in url Encode additional coordinates in url Sep 14, 2023
@philippotto
Copy link
Member Author

@normanrz What do you think about the encoding? If we want to go for brevity, we could change
additionalCoordinate-t=123 to aC-t=123 in the URL.

@normanrz
Copy link
Member

@normanrz What do you think about the encoding? If we want to go for brevity, we could change
additionalCoordinate-t=123 to aC-t=123 in the URL.

I like the key=value encoding. Concise and extendable. We should've done that from the start :D
I'd prefer a shorter key, such as pos-t or aC-t.

@philippotto
Copy link
Member Author

@normanrz bump 🧋

@philippotto philippotto enabled auto-merge (squash) October 12, 2023 14:49
@philippotto philippotto merged commit 74347e6 into master Oct 12, 2023
2 checks passed
@philippotto philippotto deleted the remember-additional-coordinates branch October 12, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve view position along ND axes on page reload
2 participants