Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction management bug #7329

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Fix transaction management bug #7329

merged 6 commits into from
Sep 12, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 12, 2023

Saved multiple update groups at the same version in the committed update store, which led to updates being overwritten.
This PR changes the logic so that the update groups are saved into one before stored to the committed store under that version number.

Steps to test:

  • Create large skeletons / volumes, save, reload, should all look right

@fm3 fm3 self-assigned this Sep 12, 2023
@fm3 fm3 changed the title fix transaction management bug Fix transaction management bug Sep 12, 2023
@fm3 fm3 marked this pull request as ready for review September 12, 2023 09:34
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 I also disabled the mapping-related transaction chunking (as discussed) and tested this locally.

@fm3 fm3 enabled auto-merge (squash) September 12, 2023 10:15
@fm3 fm3 merged commit 06c8002 into master Sep 12, 2023
2 checks passed
@fm3 fm3 deleted the transactions-fix branch September 12, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants