Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for remote Zarr3-based Webknossos datasets #7372

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Oct 9, 2023

Refactors the WebknossosZarrExplorer to take the datasource-properties.json directly and just rewrite the paths. This also enables Zarr3 support for these datasets.

Steps to test:


(Please delete unneeded items, merge only when none are left open)

@normanrz normanrz requested a review from fm3 October 9, 2023 15:31
@normanrz normanrz self-assigned this Oct 9, 2023
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and works for me 🎉 Added a comment suggestion

app/models/dataset/explore/WebknossosZarrExplorer.scala Outdated Show resolved Hide resolved
Co-authored-by: Florian M <fm3@users.noreply.github.com>
@normanrz normanrz enabled auto-merge (squash) October 10, 2023 09:39
@normanrz normanrz enabled auto-merge (squash) October 10, 2023 09:49
@normanrz normanrz merged commit fe71522 into master Oct 10, 2023
2 checks passed
@normanrz normanrz deleted the explore-wk-zarr branch October 10, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants