Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segment stats for layers without segment index #7377

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Oct 11, 2023

Steps to test:

  • make sure you have a visible annotation layer without a fallback layer and without segment index, e.g. by viewing an old annotation (created before segment index was introduced) or by setting hasSegmentIndex to false in volumetracing_reducer
  • brush and right-click a segment in the viewport. make sure there are not segment stats shown. also make sure that there is no Show Segment Statistics action in the context menu in the right border segment tab.
  • click anywhere in the viewport where there is no segment and make sure the segment stats are not shown either

Issues:


(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Removed dev-only changes like prints and application.conf edits
  • Considered common edge cases I tried, I swear 😅

@dieknolle3333 dieknolle3333 self-assigned this Oct 11, 2023
@dieknolle3333 dieknolle3333 marked this pull request as draft October 11, 2023 12:46
@dieknolle3333 dieknolle3333 marked this pull request as ready for review October 11, 2023 13:10
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hotzenklotz
Copy link
Member

@dieknolle3333 dieknolle3333 enabled auto-merge (squash) October 16, 2023 11:09
@dieknolle3333 dieknolle3333 merged commit 2460d7e into master Oct 16, 2023
2 checks passed
@dieknolle3333 dieknolle3333 deleted the fix-segment-stats-no-index branch October 16, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants