Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight segment in sidebar when using search to cycle through segments #7406

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Oct 24, 2023

URL of deployed dev instance (used for testing):

Steps to test:

  • create multiple segments
  • use segment search to cycle through segments
  • segment should be highlighted in the sidebar

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Oct 24, 2023
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

I noticed a user-facing typo while I was looking at the code in the file, maybe you can quickly fix it in this PR: https://github.com/scalableminds/webknossos/blob/529b22b166c8e4e7d64447fccce2648caf2efc4d/frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx#L443C49-L443C49 (trees should be segments)

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@philippotto philippotto enabled auto-merge (squash) October 25, 2023 07:55
@philippotto philippotto merged commit 4e09069 into master Oct 25, 2023
2 checks passed
@philippotto philippotto deleted the fix-select-on-search branch October 25, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search for Segment Name jumps in viewport but does not highlight segment in Segment List
2 participants