Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uint24 support for DatasetArray-based formats (excepting ND) #7413

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 26, 2023

uint24 is webknossos’ way of handling rgb images (3×8 bytes). This is a special case and the only case where channels are supported (except splitting them into multiple layers with a channelIndex).

However, since this is still actively used (e.g. for prediction outputs in voxelytics), we need to support it also for zarr3. This PR adds this special case for readBytesXYZ in DatasetArray. Limitation: not for datasets with additionalCoordinates (ND), compare #7280.

Steps to test:

Issues:


@fm3 fm3 requested a review from frcroth October 26, 2023 07:52
@fm3 fm3 self-assigned this Oct 26, 2023
@fm3 fm3 enabled auto-merge (squash) November 1, 2023 07:47
@fm3 fm3 merged commit 43121df into master Nov 1, 2023
2 checks passed
@fm3 fm3 deleted the zarr3-uint24 branch November 1, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support loading Uint24 Zarr3 datasets
2 participants