Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Neuroglancer URIs #7416

Merged
merged 10 commits into from
Nov 8, 2023
Merged

Explore Neuroglancer URIs #7416

merged 10 commits into from
Nov 8, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Oct 30, 2023

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open a dataset in Neuroglancer and copy the URL to "Add remote dataset", e.g. this

TODOs:

Note: Some of the examples at neuroglancer can't be imported because they use URIs that are not standard-compliant, which causes an exception in the java.net.URI implementation. Specifically, that is because there are multiple number signs (#), where only one is allowed. For example, this fails.

Issues:


(Please delete unneeded items, merge only when none are left open)

@frcroth frcroth self-assigned this Oct 30, 2023
@frcroth frcroth marked this pull request as draft October 30, 2023 15:30
@frcroth frcroth changed the title Explore Neuroglancer URIs WIP: Explore Neuroglancer URIs Oct 30, 2023
@frcroth frcroth requested a review from fm3 November 8, 2023 10:26
@frcroth frcroth changed the title WIP: Explore Neuroglancer URIs Explore Neuroglancer URIs Nov 8, 2023
@frcroth frcroth marked this pull request as ready for review November 8, 2023 10:27
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :)

I tried with some examples from here https://github.com/google/neuroglancer#examples but always got Received invalid URI in the explore report. Maybe it has something to do with url encoding? I have a l ot of %7B%22 in the uris. Can you reproduce that? (I clicked open viewer, waited till the neuroglancer page is loaded, then copied the uri from the firefox address bar)

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks like that was in fact an illegal URI (double hash sign). I’d say it’s fair that we can’t take those for the moment.

@frcroth frcroth merged commit 1ba905a into master Nov 8, 2023
2 checks passed
@frcroth frcroth deleted the neuroglancer-uri-explore branch November 8, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore/Import from Neuroglancer URI
2 participants