Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme initialization #7446

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix theme initialization #7446

merged 2 commits into from
Nov 21, 2023

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Nov 20, 2023

by loading theme before main.js. Regression was introduced in #7367.

The default state initialization assumes that the active theme is already set in the HTML (see this code). Initializing the theme in the HTML too late, leads to rendering issues, because the state is never set correctly (only once the theme is switched again). I'm not sure why the initialization is that hacky, maybe to avoid flickering if the theme is set too late, otherwise 🤔

URL of deployed dev instance (used for testing):

Steps to test:

  • View a dataset in dark mode. Reload the page. The 3d viewport and the other viewport headers should be dark, not white.

(Please delete unneeded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Nov 20, 2023
@daniel-wer daniel-wer merged commit 3adeaad into master Nov 21, 2023
2 checks passed
@daniel-wer daniel-wer deleted the fix-theme branch November 21, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants