Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jobs readable for admins+teamManagers+superusers #7462

Merged
merged 7 commits into from
Dec 6, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Nov 28, 2023

The job list should still only show the jobs of the requesting user. But if an admin or teamManager or superUser hast the id/link to a job by one of their managed users, they should be able to view its properties (GET api/jobs/:id) and access exported files.

Steps to test:

  • Enable jobs (yarn enable-jobs), set up different user/admin combinations
  • As the user, run some jobs
  • Check that everyone can see exactly those jobs they are supposed to see
  • Also check export download links (for this you need a webknossos-worker. I did test it, though, and this uses the same access check as the simple GET api/jobs/:id, which can be tested without a worker)

Issues:


@fm3 fm3 self-assigned this Nov 28, 2023
@fm3 fm3 added the backend label Nov 28, 2023
@fm3 fm3 marked this pull request as ready for review November 28, 2023 12:36
@fm3 fm3 requested a review from frcroth November 28, 2023 12:36
app/models/job/Job.scala Outdated Show resolved Hide resolved
@fm3 fm3 requested a review from frcroth November 30, 2023 14:41
app/models/job/Job.scala Outdated Show resolved Hide resolved
fm3 and others added 2 commits December 6, 2023 09:18
Co-authored-by: frcroth <frcroth@users.noreply.github.com>
@fm3 fm3 enabled auto-merge (squash) December 6, 2023 09:48
@fm3 fm3 disabled auto-merge December 6, 2023 09:48
@fm3 fm3 enabled auto-merge (squash) December 6, 2023 09:55
@fm3 fm3 merged commit 3912561 into master Dec 6, 2023
2 checks passed
@fm3 fm3 deleted the job-export-download-for-admin branch December 6, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow admins to download exported files from all jobs of orga
2 participants