Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix antd deprecation warnings for Tabs.TabPane #7469

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Fix antd deprecation warnings for Tabs.TabPane #7469

merged 7 commits into from
Dec 4, 2023

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Nov 29, 2023

Antd deprecated the use of <Tabs.TabPane> components in favor of providing the tabs as an array into the tab props, e.g. <Tabs items={ ... }>. See https://4x.ant.design/components/tabs/#Usage-upgrade-after-4.23.0

In this PR I removed all remaining occurrences of <TabPane> and replaced them with the new array/object based syntax.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Typechecker does most of the formal varification
  • Open the corresponding views and check that tabs are still there / work

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz mentioned this pull request Nov 29, 2023
12 tasks
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, testing went smooth 👍

@hotzenklotz hotzenklotz merged commit 9fa24f4 into master Dec 4, 2023
2 checks passed
@hotzenklotz hotzenklotz deleted the tabpane branch December 4, 2023 09:58
@philippotto philippotto mentioned this pull request Dec 5, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of TabsPane components as they are marked as deprecated by antd v4
2 participants