Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete dataset: also clear tables for additional axes, coordinate transforms #7495

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Delete dataset: also clear tables for additional axes, coordinate transforms #7495

merged 2 commits into from
Dec 11, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Dec 11, 2023

Got some foreign key violations because these were not cleaned up properly on dataset deletion.

Steps to test:

  • use "delete on disk" in the settings page for a dataset with additional axes (4D Dataset)
  • no sql errors should appear in backend logging

Issues:

@fm3 fm3 self-assigned this Dec 11, 2023
@fm3 fm3 marked this pull request as ready for review December 11, 2023 13:27
@fm3 fm3 requested a review from frcroth December 11, 2023 13:28
@fm3 fm3 enabled auto-merge (squash) December 11, 2023 13:34
@fm3 fm3 merged commit 1de2f00 into master Dec 11, 2023
2 checks passed
@fm3 fm3 deleted the dataset-deletion-add-missing-queries branch December 11, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frcroth frcroth frcroth approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dataset_layer_coordinatetransformations not cleared when deleting dataset
2 participants
@fm3 @frcroth