Update antd to version 4.24.15 #7505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotzenklotz
commented
Jan 2, 2024
| @@ -239,7 +239,8 @@ | |||
| }, | |||
| "resolutions": { | |||
| "**/mini-store": "^1.1.0", | |||
| "**/redux": "3.7.2" | |||
| "**/redux": "3.7.2", | |||
| "**/rc-tree": "^5.7.12" | |||
There was a problem hiding this comment.
For some reason, there were several versions of rc-tree, including older ones, being imported by yarn. That leads to typescript errors are necessitates this fix.
See als Slack conversion for reference: https://scm.slack.com/archives/C5AKLAV0B/p1704200386030179
This can likely be remove in antd5.
7 tasks
philippotto
reviewed
Jan 4, 2024
| @@ -231,6 +233,7 @@ function ToolRadioButton({ | |||
| <RadioButtonWithTooltip | |||
| title={`${name} – ${description}`} | |||
| disabledTitle={`${name} – ${disabledExplanation}`} | |||
| onOpenChange={onOpenChange} | |||
There was a problem hiding this comment.
I think, the two line changes in ToolRadioButton shouldn't be necessary or are they?
There was a problem hiding this comment.
Yes, you are right, sensei.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR upgrades antd to latest 4.x release as a prerequisite to antd 5. The changelog between the current 4.24.8 and 4.24.15 version is rather unremarkable and did not hint at any major changes. https://4x.ant.design/changelog
I tested most admin view and the tracing interface by clicking around and monkey testing. Nothing came up.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)