Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify permission system for setting allowed teams during upload #7518

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 3, 2024

Fixed a bug where dataset managers were not allowed to assign teams to new datasets that they are only member of. This already worked while editing the dataset later (also for folders), but not during upload.

URL of deployed dev instance (used for testing):

Steps to test:

  • Make a user team manager and member of a team
  • As that user, upload a dataset, and assign that team to the dataset during the upload.
  • Should be allowed

Issues:


@fm3 fm3 requested a review from frcroth January 3, 2024 12:19
@fm3 fm3 self-assigned this Jan 3, 2024
Copy link
Member

@frcroth frcroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: frcroth <frcroth@users.noreply.github.com>
@fm3 fm3 requested a review from frcroth January 8, 2024 09:22
@fm3 fm3 enabled auto-merge (squash) January 8, 2024 09:47
@fm3 fm3 merged commit fbc6de1 into master Jan 8, 2024
2 checks passed
@fm3 fm3 deleted the upload-initial-teams branch January 8, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset Managers: Allow to add teams to dataset they are only member of?
2 participants