Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about overwrite mode when no voxels were changed during brush #7526

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Warn about overwrite mode when no voxels were changed during brush #7526

merged 8 commits into from
Jan 18, 2024

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 8, 2024 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • use brush or lasso tool to change voxels
  • use overwrite mode "overwrite empty" and test that a toast appears when only brushing over already existing voxels:
    image
  • brush into an empty area -> the toast should disappear

Issues:

@philippotto philippotto self-assigned this Jan 8, 2024
@philippotto @fm3
Update frontend/javascripts/oxalis/model/sagas/volumetracing_saga.tsx
bbd1a91 
Co-authored-by: Florian M <fm3@users.noreply.github.com>
daniel-wer
daniel-wer approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks for the quick PR 👍

frontend/javascripts/oxalis/model/sagas/volumetracing_saga.tsx Outdated Show resolved Hide resolved
@philippotto philippotto enabled auto-merge (squash) January 18, 2024 13:53
@philippotto philippotto merged commit 8413e0d into master Jan 18, 2024
2 checks passed
@philippotto philippotto deleted the warn-about-overwrite-mode branch January 18, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 left review comments

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philippotto @fm3 @daniel-wer