Change default dataset search mode to be recursive #7539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
approved these changes
Jan 11, 2024
| @@ -350,9 +350,9 @@ function useManagedUrlParams( | |||
| params.set("folderId", activeFolderId); | |||
| // The recursive property is only relevant when a folderId is specified. | |||
| if (searchRecursively) { | |||
| params.set("recursive", "true"); | |||
There was a problem hiding this comment.
what do you think about keeping this line? then, the url would always define the recursive behavior and we could change the default in the future without changing the semantics of urls. I don't think it's important, but it feels a bit cleaner to me. your call!
…nge-dataset-search-default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed internally.
The
recursiveprop already was true by default (see code), but parsing the url parameters on component mount effectively changed that to be false.URL of deployed dev instance (used for testing):
Steps to test:
(Please delete unneeded items, merge only when none are left open)