Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disabled worker jobs in frontend #7591

Merged
merged 16 commits into from
Mar 4, 2024
Merged

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Jan 26, 2024

This PR adds the frontend part to #7463, i.e. enabling/disabling different UI elements if a certain worker jobs is not supported by that WK instance.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Adjust the worker's supported job commands in the workers table in the Postgres DB
  • Check if the corresponding UI feature reacts either by being disabled or hidden altogether

TODOs:

  • CONVERT_TO_WKW
  • EXPORT_TIFF
  • RENDER_ANIMATION
  • COMPUTE_MESH_FILE
  • COMPUTE_SEGMENT_INDEX_FILE
  • FIND_LARGEST_SEGMENT_ID
  • INFER_NUCLEI
  • INFER_NEURONS
  • MATERIALIZE_VOLUME_ANNOTATION

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Jan 26, 2024
@hotzenklotz hotzenklotz changed the title WIP WIP Enable/Disabled worker jobs in frontend Jan 26, 2024
@hotzenklotz hotzenklotz marked this pull request as ready for review February 15, 2024 12:56
@hotzenklotz
Copy link
Member Author

@philippotto Can you please review the frontend changes. Thank you.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good, but see my few comments.

@hotzenklotz hotzenklotz changed the title WIP Enable/Disabled worker jobs in frontend Enable/Disabled worker jobs in frontend Feb 16, 2024
@hotzenklotz
Copy link
Member Author

@philippotto I applied your review suggestions / feedback. Please have a look.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hotzenklotz hotzenklotz merged commit 3c979c0 into master Mar 4, 2024
2 checks passed
@hotzenklotz hotzenklotz deleted the enable-worker-jobs branch March 4, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobs that are not available for a particular datastore should already be disabled in the frontend
3 participants