Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for analytics event ingestion #7609

Merged
merged 4 commits into from
Feb 7, 2024
Merged

fixes for analytics event ingestion #7609

merged 4 commits into from
Feb 7, 2024

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Feb 7, 2024 •
edited
Loading

Fixes for analytics event ingestion

(Please delete unneeded items, merge only when none are left open)

@normanrz normanrz requested a review from fm3 February 7, 2024 12:20
@normanrz normanrz self-assigned this Feb 7, 2024
fm3
fm3 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try with validate[Instant]? That should already handle both numerals and strings.

Otherwise, LGTM

@bulldozer-boy bulldozer-boy bot merged commit e8bfabe into master Feb 7, 2024
2 checks passed
@bulldozer-boy bulldozer-boy bot deleted the analytics-ingest-fixes branch February 7, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@normanrz normanrz

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@normanrz @fm3