Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings for antd <Collapse> components #7610

Merged
merged 11 commits into from
Feb 12, 2024

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Feb 7, 2024

Fix deprecation warnings for antd <Collapse> components. API changed to items props instead of React children/<Panel>.

See https://ant.design/components/collapse#collapsepanel

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Navaigate to any view using a <Collapse />
  • Open web dev console
  • There should not be any deprecation warnings

TODOs:

  • Fix typescript errors

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Feb 7, 2024
@hotzenklotz hotzenklotz mentioned this pull request Feb 7, 2024
14 tasks
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and testing went well mostly. I had one crash when opening the dataset settings page, though:
https://fixcollapsedeprecation.webknossos.xyz/datasets/sample_organization/2017-05-31_mSEM_scMS109_bk_100um_v01-aniso/edit

Error

frontend/javascripts/admin/voxelytics/task_list_view.tsx Outdated Show resolved Hide resolved
@hotzenklotz
Copy link
Member Author

Code looks good and testing went well mostly. I had one crash when opening the dataset settings page, though: https://fixcollapsedeprecation.webknossos.xyz/datasets/sample_organization/2017-05-31_mSEM_scMS109_bk_100um_v01-aniso/edit

Error

Well spotted. I pushed a fix that should resolve this crash.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hotzenklotz hotzenklotz enabled auto-merge (squash) February 12, 2024 15:57
@hotzenklotz hotzenklotz merged commit 8a78ae6 into master Feb 12, 2024
2 checks passed
@hotzenklotz hotzenklotz deleted the fix-collapse-deprecation branch February 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants