Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to only track time when there are significant changes #7627

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Feb 14, 2024

Set the new application.conf option webKnossos.timeTrackingOnlyWithSignificantChanges to false to disable time tracking for changes where only camera movements happened.

Note that the timeTrackingPause is still active, so if there are “significant changes” within that duration again, the timespans will be extended.

Steps to test:

  • Set option to true, no time tracking for moving cam and saving
  • Set option to false, time tracking for moving cam and saving

Issues:


@frcroth frcroth requested a review from fm3 February 14, 2024 13:02
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I don’t think we need to group the config keys just yet. Please see my comment about simplifying the boolean expression

app/controllers/WKRemoteTracingStoreController.scala Outdated Show resolved Hide resolved
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I wrote a follow-up issue for proofreading annotations, since they don’t get “automatically” time-tracked anymore if this new config option is true. #7637

@frcroth frcroth merged commit 9213f79 into master Feb 21, 2024
2 checks passed
@frcroth frcroth deleted the time-tracking-only-with-significant-changes branch February 21, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve measurement of spent time for tasks/annotations
2 participants