Dashboard annotation list: skip deleted annotations #7628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frcroth
approved these changes
Feb 15, 2024
philippotto
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Dashboard annotation list: skip deleted annotations * num in changelog
Merged
philippotto
added a commit
that referenced
this pull request
Feb 15, 2024
* Dashboard annotation list: skip deleted annotations (#7628) * Dashboard annotation list: skip deleted annotations * num in changelog * Release 24.02.1 --------- Co-authored-by: Florian M <fm3@users.noreply.github.com>
fm3
added a commit
that referenced
this pull request
Feb 22, 2024
* Dashboard annotation list: skip deleted annotations (#7628) * Dashboard annotation list: skip deleted annotations * num in changelog * Release 24.02.1 * Fix sql error in annotation list query (#7632) * Release 24.02.2 * Release 24.02.3 * Apply suggestions from code review Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com> --------- Co-authored-by: Philipp Otto <philipp.4096@gmail.com> Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The annotation list attempted to include deleted annotations, which fails in the frontend, since some properties may become null.
Was a regression introduced in #7410