Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NML uploader styling #7641

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Fix NML uploader styling #7641

merged 4 commits into from
Feb 22, 2024

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Feb 20, 2024

This PR fixes some stylings for NML uploader / drag and drop area as a follow up to antd v5.

Before / Fixes this:
image

URL of deployed dev instance (used for testing):

Steps to test:

  • Go to annotation interface
  • Drag and drop a NML file over viewport
  • DnD area should have a nice background color
  • Test in light and dark mode / theme

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Feb 20, 2024
@@ -324,8 +323,8 @@ button.narrow {
top: 100px;
width: 400px;
height: 250px;
background: var(--ant-modal-content-bg);
border-radius: 4px;
background: var(--ant-color-bg-container);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ant modal background color vars are not available globally but only for <Modal /> components. :-/

Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM 👍

@hotzenklotz hotzenklotz enabled auto-merge (squash) February 22, 2024 10:32
@hotzenklotz hotzenklotz merged commit 65ca540 into master Feb 22, 2024
2 checks passed
@hotzenklotz hotzenklotz deleted the fix-nml-upload branch February 22, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants