Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid left join fanout effect in annotation list query #7659

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 29, 2024

I went through queries that have LEFT JOIN looking for possible fanout effect.

Most other queries should be fine

  • Dataset list is already ok (inline subqueries)
  • Folder access queries are ok (duplicates don’t hurt)
  • Progress reports are ok (subqueries)
  • Task assignment query is ok (duplicates don’t hurt)

I did not check the voxelytics queries, @normanrz maybe you could have a quick look there?

URL of deployed dev instance (used for testing):

Steps to test:

  • For some annotations, set multiple shared teams in annotation share modal
  • annotation list in dashboard should not contain duplicate teams

Issues:


@fm3 fm3 self-assigned this Feb 29, 2024
@fm3 fm3 requested a review from frcroth February 29, 2024 12:59
@fm3
Copy link
Member Author

fm3 commented Mar 4, 2024

(for the record, Norman said he checked the voxelytics queries, should be fine too)

@fm3 fm3 enabled auto-merge (squash) March 4, 2024 09:24
@fm3 fm3 merged commit 14e75d8 into master Mar 4, 2024
2 checks passed
@fm3 fm3 deleted the avoid-join-fanout branch March 4, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit all queries containing LEFT JOIN for fanout effect causing duplicates
2 participants