Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display dataset used storage #7677

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Display dataset used storage #7677

merged 9 commits into from
Mar 7, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 7, 2024

Show used storage of datasets.

Steps to test:

  • provoke a storage scan by setting both fetchUsedStorage.rescanInterval and fetchUsedStorage.ticketInterval to 1 minute, and reportUsedStorage.enabled to true
  • in dashboard, click on a number of datasets to check displayed size (should be hidden for remote datasets)

TODOs:

  • Backend
    • include used storage in dataset json
  • Frontend
    • display the info in the sidebar of the dataset list in dashboard
    • hide values <10KB to avoid confusion

Issues:


@fm3 fm3 marked this pull request as ready for review March 7, 2024 13:22
@fm3 fm3 changed the title WIP: Display dataset used storage Display dataset used storage Mar 7, 2024
@fm3 fm3 self-assigned this Mar 7, 2024
@fm3 fm3 requested a review from normanrz March 7, 2024 13:23
frontend/javascripts/types/api_flow_types.ts Outdated Show resolved Hide resolved
Co-authored-by: Norman Rzepka <code@normanrz.com>
@fm3 fm3 enabled auto-merge (squash) March 7, 2024 13:27
{fullDataset?.usedStorageBytes && fullDataset.usedStorageBytes > 10000 ? (
<div style={{ marginBottom: 4 }}>
<div className="sidebar-label">Used Storage</div>
<Tooltip title={`${fullDataset.usedStorageBytes} Bytes`} placement="left">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, showing the bytes in the tooltip doesn't really add a value. I'd rather say something like "Note that linked layer's aren't measured" or something like that.

@normanrz normanrz disabled auto-merge March 7, 2024 13:47
@fm3 fm3 merged commit 5222a04 into master Mar 7, 2024
2 checks passed
@fm3 fm3 deleted the dataset-size-bytes branch March 7, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show dataset storage size in dataset list
3 participants