Don't let toast elapse in background in some browsers #7741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dieknolle3333
changed the title
dieknolle3333
commented
Apr 10, 2024
| @@ -700,11 +700,11 @@ async function applyLayerState(stateByLayer: UrlStateByLayer) { | |||
| // The name of the layer could have changed if a volume tracing was created from a viewed annotation | |||
| effectiveLayerName = getLayerByName(dataset, layerName, true).name; | |||
| } catch (e) { | |||
| console.error(e); | |||
There was a problem hiding this comment.
In cases like this I didnt omit the separate log because Error not only has a message, but also a type, and I didnt want that to be omitted. Let me know if you think I should change that :)
philippotto
reviewed
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
- upload a larger dataset and switch the tab
- wait until the upload is done for a while
- go back to the WK tab and make sure both toasts are shown at least for a very short time (there should be at least two toasts after switching back)
Issues:
(Please delete unneeded items, merge only when none are left open)