Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Tracking for Shared Annotations + Editable Mappings #7749

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Time Tracking for Shared Annotations + Editable Mappings #7749

merged 3 commits into from
Apr 15, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 11, 2024 •
edited

  • Time tracking for editable mapping updates (they now also count as significant changes)
  • Count interactions with that have othersMayEdit=true, include annotation reference. This means that annotations can now have timespans with multiple users even when the owner does not change.
  • Interactions with annotations that are not yours and that do not have othersMayEdit=true don’t create timespans at all anymore (those previously had no annotation reference and so were basically useless)

Steps to test:

  • Interact with shared annotations, time tracking should look as expected
  • Interact with proofreading annotations, time tracking should look as expected

Issues:

@fm3 fm3 self-assigned this Apr 11, 2024
@fm3 fm3 marked this pull request as ready for review April 11, 2024 12:48
@fm3 fm3 requested a review from normanrz April 11, 2024 12:48
@fm3 fm3 enabled auto-merge (squash) April 15, 2024 08:06
@fm3 fm3 merged commit 7b13f15 into master Apr 15, 2024
2 checks passed
@fm3 fm3 deleted the time-tracking-shared branch April 15, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees

@fm3 fm3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time Tracking for Shared Annotations Time Tracking for Proofreading Annotations
2 participants
@fm3 @normanrz