Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Infer Mitochondria Job #7752

Merged
merged 14 commits into from
Apr 22, 2024
Merged

Add Infer Mitochondria Job #7752

merged 14 commits into from
Apr 22, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 15, 2024 •
edited

Adds infer_mitochondria worker job (for now for superusers only)

Corresponding PR in voxelytics: https://github.com/scalableminds/voxelytics/pull/3504

Steps to test:

  • Set up worker with vx branch infer-mitochondria-workflow, in wk, run yarn enable-jobs, open dataset/annotation in wk, create a bbox with a mito, hit “AI Analysis”, run mito inferral job, result should look ok
  • (no changelog for now, since this is still behind the superUser condition)
  • Updated migration guide if applicable
  • Removed dev-only changes like prints and application.conf edits
  • Considered common edge cases

@fm3 fm3 self-assigned this Apr 15, 2024
@fm3 fm3 added the frontend label Apr 18, 2024
@Tobias314 Tobias314 changed the title WIP: Add Infer Mitochondria Job Add Infer Mitochondria Job Apr 18, 2024
@fm3 fm3 marked this pull request as ready for review April 18, 2024 14:17
@fm3 fm3 requested a review from philippotto April 18, 2024 14:38
hotzenklotz
hotzenklotz approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Excited for the first mitos!

frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx Outdated Show resolved Hide resolved
frontend/javascripts/admin/dataset/dataset_upload_view.tsx Show resolved Hide resolved
@Tobias314 @hotzenklotz
Update frontend/javascripts/oxalis/view/action-bar/starting_job_modal…
cabce15 
…s.tsx

Co-authored-by: Tom Herold <tom.herold@scalableminds.com>
philippotto
philippotto approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :) see my one comment about a copy&paste error, though.

Tobias314 and others added 2 commits April 22, 2024 10:03
@Tobias314 @philippotto
Update frontend/javascripts/oxalis/view/action-bar/starting_job_modal…
5b0c16a 
…s.tsx

Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
@Tobias314
Format
b2e7991
@Tobias314 Tobias314 enabled auto-merge (squash) April 22, 2024 08:50
@Tobias314 Tobias314 merged commit bbfc4ef into master Apr 22, 2024
2 checks passed
@Tobias314 Tobias314 deleted the infer-mitochondria branch April 22, 2024 09:06
@fm3 fm3 mentioned this pull request Jun 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzenklotz hotzenklotz hotzenklotz approved these changes

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

@Tobias314 Tobias314

Labels
backend frontend jobs new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fm3 @hotzenklotz @philippotto @Tobias314