Disable UI starting dataset creating jobs for unprivileged users #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-allow-privilegde-user-dataset-creation-jobs
MichaelBuessemeyer
changed the title
frontend/stylesheets/dark.less
Outdated
There was a problem hiding this comment.
I formatted this page with prettier, as biome currently does not support formatting css.
See: biomejs/biome#1285
philippotto
reviewed
Apr 25, 2024
| @@ -428,6 +428,7 @@ class ReactRouter extends React.Component<Props> { | |||
| <SecuredRouteWithErrorBoundary | |||
| isAuthenticated={isAuthenticated} | |||
| path="/datasets/upload" | |||
| requiresAdminOrManagerRole | |||
There was a problem hiding this comment.
I think, this prop can be added to a few other components:
path="/users/:userId/details"
path="/users"
path="/teams"
path="/timetracking"
path="/reports/projectProgress"
path="/reports/availableTasks"
path="/tasks"
path="/tasks/create"
path="/tasks/:taskId/edit"
path="/tasks/:taskId"
path="/projects"
path="/projects/create"
path="/projects/:projectId/tasks"
path="/projects/:projectId/edit"
path="/datasets/:organizationName/:datasetName/import"
path="/datasets/:organizationName/:datasetName/edit"
path="/taskTypes"
path="/taskTypes/create"
path="/taskTypes/:taskTypeId/edit"
path="/taskTypes/:taskTypeId/tasks"
path="/taskTypes/:taskTypeId/projects"
path="/scripts/create"
path="/scripts/:scriptId/edit"
path="/scripts"
There was a problem hiding this comment.
Thanks for listing all other components 👍
Initially, I though that this should be added in a separate PR but doing it already here is also fine to me and might also save some time.
I'll test each route as admin and non-admin later :)
There was a problem hiding this comment.
I'll test each route as admin and non-admin later :)
Done, worked out as expected 👍. All pages/view listed above are available to sample@scm.io but not to sample2@scm.io
…y-allow-privilegde-user-dataset-creation-jobs
MichaelBuessemeyer
deleted the
only-allow-privilegde-user-dataset-creation-jobs
branch
dieknolle3333
pushed a commit
that referenced
this pull request
May 8, 2024
* disable ui starting dataset creating jobs for non-admin/ datasetmanager users * hide materialize merger mode button instead of disabling it * check for is team manager as well (and not only admin or dataset manager roles) * re-allow merge with fallback layer for team managers * add changelog entry * add improved image to permission enforcer view / forbidden view * add manager/admin permissions required view to privileged views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the UI elements allowing the creation of a new dataset as an output of a job for normal unprivileged users.
URL of deployed dev instance (used for testing):
Steps to test:
<host-ulr-part>/datasets/uploadshould now show a 403 error pageOpen question:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)