Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading CompressedSegmentation with uint32 data #7757

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 16, 2024

The old code padded every 32-bit output value with another 32 zeroes due to the to-long conversion.

As mentioned in #6947 we didn’t have a uint32 test dataset yet when implementing this.

I also removed some superfluous parentheses.

Steps to test:


  • Updated changelog
  • Needs datastore update after deployment

@fm3 fm3 self-assigned this Apr 16, 2024
@fm3 fm3 marked this pull request as ready for review April 16, 2024 09:50
@fm3 fm3 requested a review from normanrz April 16, 2024 09:50
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@fm3 fm3 enabled auto-merge (squash) April 16, 2024 09:53
@fm3 fm3 merged commit 0644162 into master Apr 16, 2024
2 checks passed
@fm3 fm3 deleted the compressedseg32 branch April 16, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants