Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume annotation downsampling #7759

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fix volume annotation downsampling #7759

merged 2 commits into from
Apr 16, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 16, 2024

getFallbackLayer queries the dataset info from wk by the tracingId. But since downsampling is part of the duplicate route, the new tracingId is not yet known by the wk side. However, the fallback layer should not change in the duplicate, so using the old id is valid.

Steps to test:

  • Create volume annotation with resolution restriction, brush some (multiple sections)
  • Hit downsample button in the sidebar, confirm
  • Should work, yield valid annotation

Issues:


@fm3 fm3 self-assigned this Apr 16, 2024
@fm3 fm3 requested a review from normanrz April 16, 2024 12:57
@fm3 fm3 enabled auto-merge (squash) April 16, 2024 12:59
@fm3 fm3 merged commit a33b546 into master Apr 16, 2024
2 checks passed
@fm3 fm3 deleted the fix-volume-downsampling branch April 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downsampling of volume annotation is broken
2 participants