Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for meshfiles version 2 and older #7764

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 18, 2024

Removes support for the old meshfile format

Steps to test:

  • Load some precomputed meshes, with and without mappings

Issues:


@fm3 fm3 self-assigned this Apr 18, 2024
@fm3 fm3 changed the title WIP: Remove support for meshfiles version 2 and older Remove support for meshfiles version 2 and older Apr 22, 2024
@fm3 fm3 marked this pull request as ready for review April 22, 2024 12:45
@fm3 fm3 requested a review from philippotto April 22, 2024 12:46
@fm3 fm3 added the frontend label Apr 22, 2024
@fm3 fm3 requested a review from normanrz April 22, 2024 12:46
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend looks good 👍

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

front-end looks great, too 🥇

@@ -104,8 +104,7 @@ import { AnnotationTypeFilterEnum } from "./statistic/project_and_annotation_typ
const MAX_SERVER_ITEMS_PER_RESPONSE = 1000;

export * from "./api/token";
export * as meshV3 from "./api/mesh_v3";
export * as meshV0 from "./api/mesh_v0";
export * as meshApi from "./api/mesh";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@fm3 fm3 merged commit 389bff6 into master Apr 22, 2024
2 checks passed
@fm3 fm3 deleted the no-old-meshfiles branch April 22, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support of old mesh files
3 participants