Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up code for user compact list #7808

Merged
merged 8 commits into from
May 21, 2024
Merged

Clean up code for user compact list #7808

merged 8 commits into from
May 21, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 16, 2024 •
edited
Loading

Since we now have GetValue SQL implicits for ObjectId and Instant, we can avoid some conversions in the UserCompactInfo codepaths. Also removed some other unused stuff

URL of deployed dev instance (used for testing):

Steps to test:

  • Open user list view, should still look sensible

@fm3 fm3 self-assigned this May 16, 2024
@fm3 fm3 changed the title cleanup code for user compact list clean up code for user compact list May 16, 2024
@fm3 fm3 changed the title clean up code for user compact list Clean up code for user compact list May 16, 2024
@fm3 fm3 marked this pull request as ready for review May 16, 2024 13:44
MichaelBuessemeyer
MichaelBuessemeyer approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🌮
thanks for the refactoring 👍

I checked the code and also tested with the dev deployment 🚀

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
app/models/user/UserService.scala Show resolved Hide resolved
app/models/user/User.scala Show resolved Hide resolved
@fm3 fm3 enabled auto-merge (squash) May 21, 2024 06:16
@fm3 fm3 merged commit 0202754 into master May 21, 2024
2 checks passed
@fm3 fm3 deleted the user-compact-cleanup branch May 21, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBuessemeyer MichaelBuessemeyer MichaelBuessemeyer approved these changes

Assignees

@fm3 fm3

Labels
backend refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fm3 @MichaelBuessemeyer