Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark SCP-025 as completed #95

Merged
merged 2 commits into from Apr 8, 2022
Merged

Mark SCP-025 as completed #95

merged 2 commits into from Apr 8, 2022

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented Apr 6, 2022

No description provided.

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in @julienrf! I'm going to tag @DanielaSfregola on here since she sponsored this proposal. I know it came up last meeting that there was desire for a blog post (which is now done), but just to go full circle with this, let's mention the blog post during this next meeting this week, ensure there are no other t's to cross or i's to dot, and then we'll merge this in if there are no other concerns.

@SethTisue SethTisue marked this pull request as draft April 6, 2022 23:29
@ckipp01 ckipp01 marked this pull request as ready for review April 8, 2022 17:58
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and pushed a commit on top that added a link to the blog post about this. LGTM!

@ckipp01 ckipp01 merged commit e46ba8e into main Apr 8, 2022
@ckipp01 ckipp01 deleted the update-scp-25 branch April 8, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants