-
Notifications
You must be signed in to change notification settings - Fork 203
/
BaseCompileSpec.scala
1875 lines (1670 loc) · 64.9 KB
/
BaseCompileSpec.scala
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package bloop
import java.io.ByteArrayOutputStream
import java.io.PrintStream
import java.nio.charset.StandardCharsets
import java.nio.file.Files
import java.nio.file.Paths
import java.util.concurrent.TimeUnit
import scala.concurrent.Await
import scala.concurrent.duration.Duration
import scala.concurrent.duration.FiniteDuration
import scala.util.control.NonFatal
import bloop.cli.CommonOptions
import bloop.cli.ExitStatus
import bloop.config.Config
import bloop.engine.ExecutionContext
import bloop.engine.Feedback
import bloop.engine.NoPool
import bloop.io.AbsolutePath
import bloop.io.Environment.LineSplitter
import bloop.io.Environment.lineSeparator
import bloop.io.RelativePath
import bloop.io.{Paths => BloopPaths}
import bloop.logging.RecordingLogger
import bloop.task.Task
import bloop.testing.DiffAssertions
import bloop.util.BaseTestProject
import bloop.util.BuildUtil
import bloop.util.TestUtil
abstract class BaseCompileSpec extends bloop.testing.BaseSuite {
protected def TestProject: BaseTestProject
protected def extraCompilationMessageOutput: String = ""
protected def processOutput(output: String) = output
test("compile a project twice with no input changes produces a no-op") {
TestUtil.withinWorkspace { workspace =>
val sources = List(
"""/main/scala/Foo.scala
|class Foo
""".stripMargin
)
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(workspace, "a", sources)
val projects = List(`A`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`A`)
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, projects)
val secondCompiledState = compiledState.compile(`A`)
assertExitStatus(secondCompiledState, ExitStatus.Ok)
assertValidCompilationState(secondCompiledState, projects)
assertExistingInternalClassesDir(secondCompiledState)(compiledState, projects)
assertExistingInternalClassesDir(secondCompiledState)(secondCompiledState, projects)
assertSameExternalClassesDirs(compiledState, secondCompiledState, projects)
logger.debugs.foreach { debug =>
assert(!debug.contains("Classpath hash changed"))
}
}
}
test("compile a project, delete an analysis and then write it back during a no-op compilation") {
TestUtil.withinWorkspace { workspace =>
val sources = List(
"""/main/scala/Foo.scala
|class Foo
""".stripMargin
)
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(workspace, "a", sources)
val projects = List(`A`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`A`)
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, projects)
assertNoDiff(
logger.compilingInfos.mkString(lineSeparator),
s"""
|Compiling a (1 Scala source)
""".stripMargin
)
val analysisFile = compiledState.getProjectFor(`A`).analysisOut
assert(analysisFile.exists)
Files.delete(analysisFile.underlying)
val secondCompiledState = compiledState.compile(`A`)
assertExitStatus(secondCompiledState, ExitStatus.Ok)
assertValidCompilationState(secondCompiledState, projects)
assert(analysisFile.exists)
// Logger should contain only the log from the previous compile, as this is a no-op
assertNoDiff(
logger.compilingInfos.mkString(lineSeparator),
s"""
|Compiling a (1 Scala source)
""".stripMargin
)
}
}
test("compile build incrementally sourcing from an analysis file") {
TestUtil.withinWorkspace { workspace =>
object Sources {
val `A.scala` =
"""/A.scala
|class A
""".stripMargin
val `B.scala` =
"""/B.scala
|class B extends A
""".stripMargin
}
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(workspace, "a", List(Sources.`A.scala`))
val `B` = TestProject(workspace, "b", List(Sources.`B.scala`), List(`A`))
val projects = List(`A`, `B`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`B`)
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, projects)
// This state loads the previous analysis from the persisted file
val independentLogger = new RecordingLogger(ansiCodesSupported = false)
val independentState = loadState(workspace, projects, independentLogger)
assertSuccessfulCompilation(independentState, projects, isNoOp = false)
// Assert that it's a no-op even if we sourced from the analysis
val secondCompiledState = independentState.compile(`B`)
assertExitStatus(secondCompiledState, ExitStatus.Ok)
assertSuccessfulCompilation(secondCompiledState, projects, isNoOp = true)
assertValidCompilationState(secondCompiledState, projects)
assertExistingInternalClassesDir(secondCompiledState)(compiledState, projects)
assertExistingInternalClassesDir(secondCompiledState)(secondCompiledState, projects)
assertSameExternalClassesDirs(compiledState, secondCompiledState, projects)
}
}
test(s"compile scala 3 build incrementally") {
TestUtil.withinWorkspace { workspace =>
object Sources {
val `A.scala` =
"""/A.scala
|class A { def a = 1 }
""".stripMargin
val `A2.scala` =
"""/A.scala
|class A { def a = 2 }
""".stripMargin
}
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(workspace, "a", List(Sources.`A.scala`), scalaVersion = Some("3.1.1"))
val projects = List(`A`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`A`)
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, projects)
assertIsFile(writeFile(`A`.srcFor("A.scala"), Sources.`A2.scala`))
val secondCompiledState = compiledState.compile(`A`)
assertExitStatus(secondCompiledState, ExitStatus.Ok)
assertSuccessfulCompilation(secondCompiledState, projects, isNoOp = false)
assertValidCompilationState(secondCompiledState, projects)
assertSameExternalClassesDirs(compiledState, secondCompiledState, projects)
}
}
test("compile project / clean / compile it again") {
TestUtil.withinWorkspace { workspace =>
val sources = List(
"""/main/scala/Foo.scala
|class Foo
""".stripMargin
)
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(workspace, "a", sources)
val projects = List(`A`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`A`)
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, projects)
assertNoDiff(
logger.compilingInfos.mkString(lineSeparator),
s"""
|Compiling a (1 Scala source)
""".stripMargin
)
val cleanState = compiledState.clean(`A`)
val secondCompiledState = cleanState.compile(`A`)
assertExitStatus(secondCompiledState, ExitStatus.Ok)
assertValidCompilationState(secondCompiledState, projects)
assertDifferentExternalClassesDirs(compiledState, secondCompiledState, projects)
assertNonExistingInternalClassesDir(secondCompiledState)(compiledState, projects)
assertNoDiff(
logger.compilingInfos.mkString(lineSeparator),
s"""
|Compiling a (1 Scala source)
|Compiling a (1 Scala source)
""".stripMargin
)
}
}
test("simulate an incremental compiler session") {
TestUtil.withinWorkspace { workspace =>
object Sources {
val `A.scala` =
"""/A.scala
|object A {
| def foo(s: String) = s.toString
|}
""".stripMargin
val `Bar.scala` =
"""/Bar.scala
|class Bar {
| println("Dummy class")
|}
""".stripMargin
val `B.scala` =
"""/B.scala
|object B {
| println(A.foo(""))
|}
""".stripMargin
// Second (non-compiling) version of `A`
val `A2.scala` =
"""/A.scala
|object A {
| def foo(i: Int) = i.toString
|}
""".stripMargin
// Third (compiling) version of `A`
val `A3.scala` =
"""/A.scala
|object A {
| def foo(s: String) = "asdfasdf"
|}
""".stripMargin
}
val `A` = TestProject(workspace, "a", List(Sources.`A.scala`, Sources.`Bar.scala`))
val `B` = TestProject(workspace, "b", List(Sources.`B.scala`), List(`A`))
val logger = new RecordingLogger(ansiCodesSupported = false)
val projects = List(`A`, `B`)
val initialState = loadState(workspace, projects, logger)
val compiledState = initialState.compile(`B`)
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, List(`A`, `B`))
assertNoDiff(
logger.compilingInfos.mkString(lineSeparator),
"""Compiling a (2 Scala sources)
|Compiling b (1 Scala source)""".stripMargin
)
assertIsFile(writeFile(`A`.srcFor("A.scala"), Sources.`A2.scala`))
val secondCompiledState = compiledState.compile(`B`)
assertExitStatus(secondCompiledState, ExitStatus.CompilationError)
assertSameExternalClassesDirs(compiledState, secondCompiledState, projects)
assertValidCompilationState(secondCompiledState, List(`A`))
// The internal classes dir for `A` should not exist, B failed to compile but A succeeded
assertNonExistingInternalClassesDir(secondCompiledState)(compiledState, List(`A`))
assertInvalidCompilationState(
secondCompiledState,
List(`B`),
existsAnalysisFile = true,
hasPreviousSuccessful = true,
hasSameContentsInClassesDir = true
)
val targetBPath = TestUtil.universalPath("b/src/B.scala")
assertNoDiff(
logger.renderErrors(exceptContaining = "Failed to compile"),
s"""[E1] ${targetBPath}:2:17
| type mismatch;
| found : String("")
| required: Int
| L2: println(A.foo(""))
| ^
|${targetBPath}: L2 [E1]""".stripMargin
)
assertIsFile(writeFile(`A`.srcFor("A.scala"), Sources.`A.scala`))
val thirdCompiledState = secondCompiledState.compile(`B`)
assertExitStatus(thirdCompiledState, ExitStatus.Ok)
assertValidCompilationState(thirdCompiledState, List(`A`, `B`))
assertSameExternalClassesDirs(compiledState, thirdCompiledState, projects)
/*
* Scenario: class files get removed from external classes dir.
* Expected: compilation succeeds (no-op) and external classes dir is repopulated.
*/
BloopPaths.delete(AbsolutePath(`B`.config.classesDir))
val fourthCompiledState = thirdCompiledState.compile(`B`)
assertExitStatus(fourthCompiledState, ExitStatus.Ok)
assertValidCompilationState(fourthCompiledState, List(`A`, `B`))
assertSameExternalClassesDirs(compiledState, fourthCompiledState, projects)
/*
* Scenario: one class file is modified in the external classes dir and a source file changes.
* Expected: incremental compilation succeeds and external classes dir is repopulated.
*/
writeFile(`A`.externalClassFileFor("Bar.class"), "incorrect class file contents")
assertIsFile(writeFile(`A`.srcFor("A.scala"), Sources.`A3.scala`))
val fifthCompiledState = fourthCompiledState.compile(`B`)
assertExitStatus(fifthCompiledState, ExitStatus.Ok)
assertValidCompilationState(fifthCompiledState, List(`A`, `B`))
assertIsFile(`A`.externalClassFileFor("Bar.class"))
/*
* Scenario: a classes directory of the last successful result is removed.
* Expected: we use an empty result instead.
*/
BloopPaths.delete(fifthCompiledState.getLastClassesDir(`A`).get)
BloopPaths.delete(fifthCompiledState.getLastClassesDir(`B`).get)
val sixthCompiledState = fifthCompiledState.compile(`B`)
assertExitStatus(sixthCompiledState, ExitStatus.Ok)
assertValidCompilationState(sixthCompiledState, List(`A`, `B`))
assertNoDiff(
logger.compilingInfos.mkString(lineSeparator),
"""Compiling a (2 Scala sources)
|Compiling b (1 Scala source)
|Compiling a (1 Scala source)
|Compiling b (1 Scala source)
|Compiling a (1 Scala source)
|Compiling a (1 Scala source)
|Compiling a (2 Scala sources)
|Compiling b (1 Scala source)""".stripMargin
)
// Check that initial classes directory doesn't exist either
assertNonExistingInternalClassesDir(secondCompiledState)(compiledState, List(`A`))
def listClassesDirs(dir: AbsolutePath) =
bloop.io.Paths.list(dir).filter(_.isDirectory).map(ap => ap.toRelative(dir).syntax)
// There should only be one external classes dir: the one coming from the CLI session
assert(listClassesDirs(`A`.clientClassesRootDir).size == 1)
val internalClassesRootDir =
CompileOutPaths.createInternalClassesRootDir(AbsolutePath(`A`.config.out))
assert(listClassesDirs(internalClassesRootDir).size == 1)
}
}
test("compile a build with diamond shape and check basic compilation invariants") {
TestUtil.withinWorkspace { workspace =>
object Sources {
val `A.scala` =
"""/A.scala
|package p0
|class A
""".stripMargin
val `B.scala` =
"""/B.scala
|package p1
|class B extends p0.A
""".stripMargin
val `C.scala` =
"""/C.scala
|package p2
|class C extends p0.A
""".stripMargin
val `D.scala` =
"""/D.scala
|package p3
|trait D
""".stripMargin
val `E.scala` =
"""/E.scala
|package p4
|import p2.C
|object E extends p1.B with p3.D
""".stripMargin
val `F.scala` =
"""/F.scala
|package p5
|import p3.NotFound
|class F
""".stripMargin
}
val `Empty` = TestProject(workspace, "empty", Nil)
val `A` = TestProject(workspace, "a", List(Sources.`A.scala`), List(`Empty`))
val `B` = TestProject(workspace, "b", List(Sources.`B.scala`), List(`A`))
val `C` = TestProject(workspace, "c", List(Sources.`C.scala`), List(`A`))
val `D` = TestProject(workspace, "d", List(Sources.`D.scala`), List(`B`, `C`))
val `E` = TestProject(workspace, "e", List(Sources.`E.scala`), List(`A`, `B`, `C`, `D`))
val `F` = TestProject(workspace, "f", List(Sources.`F.scala`), List(`A`, `B`, `C`, `D`))
val logger = new RecordingLogger(ansiCodesSupported = false)
val projects = List(`A`, `B`, `C`, `D`, `E`, `F`)
val initialState = {
// Reproduce and test https://github.com/scalacenter/bloop/issues/708
val configDir = TestProject.populateWorkspace(workspace, projects ++ List(`Empty`))
assertIsFile(configDir.resolve("empty.json"))
Files.delete(configDir.resolve("empty.json").underlying)
new TestState(
TestUtil.loadTestProject(configDir.underlying, logger, false)
)
}
val compiledState = initialState.compile(`E`)
assertExitStatus(compiledState, ExitStatus.Ok)
// Only the build graph of `E` is compiled successfully
assertValidCompilationState(compiledState, List(`A`, `B`, `C`, `D`, `E`))
assertEmptyCompilationState(compiledState, List(`F`))
assertNoDiff(
logger.compilingInfos.sorted.mkString(lineSeparator),
"""Compiling a (1 Scala source)
|Compiling b (1 Scala source)
|Compiling c (1 Scala source)
|Compiling d (1 Scala source)
|Compiling e (1 Scala source)""".stripMargin
)
assertNoDiff(
logger.warnings.sorted.mkString(lineSeparator),
Feedback.detectMissingDependencies(`A`.config.name, List(`Empty`.config.name)).get
)
}
}
test("compile java code depending on scala code") {
TestUtil.withinWorkspace { workspace =>
object Sources {
val `A.scala` =
"""/A.scala
|package a
|object A {
| val HelloWorld: String = "Hello World!"
|}""".stripMargin
val `B.java` =
"""/B.java
|package b;
|import a.A$;
|public class B {
| public void entrypoint(String[] args) {
| A$ a = A$.MODULE$;
| System.out.println(a.HelloWorld());
| }
|}""".stripMargin
val `C.scala` =
"""/C.scala
|package b
|object C {
| println(a.A.HelloWorld)
| println((new B).entrypoint(Array()))
|}""".stripMargin
}
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(workspace, "a", List(Sources.`A.scala`))
val `B` = TestProject(workspace, "b", List(Sources.`B.java`, Sources.`C.scala`), List(`A`))
val projects = List(`A`, `B`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`B`)
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, projects)
}
}
test("compile after moving a class across project + invalidating symbol in a dependent project") {
TestUtil.withinWorkspace { workspace =>
object Sources {
val `Foo.scala` =
"""/Foo.scala
|package common
|import Enrichments._
|class Foo
""".stripMargin
// A dummy file to avoid surpassing the 50% changed sources and trigger a full compile
val `Dummy.scala` =
"""/Dummy.scala
|package common
|class Dummy
""".stripMargin
// A second dummy file
val `Dummy2.scala` =
"""/Dummy2.scala
|package common
|class Dummy2
""".stripMargin
val `Enrichments.scala` =
"""/Enrichments.scala
|package common
|object Enrichments {}
""".stripMargin
val `Enrichments2.scala` =
"""/Enrichments.scala
|package common
|object Enrichments {
| implicit class XtensionString(str: String) {
| def isGreeting: Boolean = str == "Hello world"
| }
|}
""".stripMargin
val `Bar.scala` =
"""/Bar.scala
|package common
|import Enrichments._
|class Bar {
| val foo: Foo = new Foo
| def hello: String = "hello"
| println(hello)
|}
""".stripMargin
val `Baz.scala` =
"""/Baz.scala
|package common
|import Enrichments._
|class Baz extends Bar
""".stripMargin
}
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(workspace, "a", List(Sources.`Foo.scala`, Sources.`Enrichments.scala`))
val sourcesB = List(
Sources.`Bar.scala`,
Sources.`Baz.scala`,
Sources.`Dummy.scala`,
Sources.`Dummy2.scala`
)
val `B` = TestProject(workspace, "b", sourcesB, List(`A`))
val projects = List(`A`, `B`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`B`)
val compiledStateBackup = compiledState.backup
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, projects)
// Move `Bar.scala` from `B` to `A`; code still compiles
Files.move(
`B`.srcFor("Bar.scala").underlying,
`A`.srcFor("Bar.scala", exists = false).underlying
)
val secondCompiledState = compiledState.compile(`B`)
assertNoDiff(logger.errors.mkString(lineSeparator), "")
assertExitStatus(secondCompiledState, ExitStatus.Ok)
assertValidCompilationState(secondCompiledState, projects)
assertDifferentExternalClassesDirs(secondCompiledState, compiledStateBackup, projects)
writeFile(`A`.srcFor("Enrichments.scala"), Sources.`Enrichments2.scala`)
val thirdCompiledState = secondCompiledState.compile(`B`)
assertNoDiff(logger.errors.mkString(lineSeparator), "")
assertExitStatus(thirdCompiledState, ExitStatus.Ok)
assertValidCompilationState(thirdCompiledState, projects)
assertDifferentExternalClassesDirs(thirdCompiledState, secondCompiledState, projects)
}
}
test("don't compile after renaming a Scala class and not its references in the same project") {
TestUtil.withinWorkspace { workspace =>
object Sources {
val `Foo.scala` =
"""/Foo.scala
|class Foo
""".stripMargin
val `Bar.scala` =
"""/Bar.scala
|class Bar {
| val foo: Foo = new Foo
|}
""".stripMargin
val `Foo2.scala` =
"""/Foo.scala
|class Foo2
""".stripMargin
val `Bar2.scala` =
"""/Bar.scala
|class Bar {
| val foo: Foo2 = new Foo2
|}
""".stripMargin
}
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(workspace, "a", List(Sources.`Foo.scala`, Sources.`Bar.scala`))
val projects = List(`A`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`A`)
val compiledStateBackup = compiledState.backup
assertValidCompilationState(compiledState, projects)
// Write nir and sjsir files to ensure the class file manager invalidates them properly
def createFakeCompileProducts(
lastClassesDir: AbsolutePath,
clientDir: AbsolutePath,
classFileName: String
): Unit = {
def copy(origin: AbsolutePath, target: AbsolutePath): Unit = {
import java.nio.file.StandardCopyOption
Files.copy(
origin.underlying,
target.underlying,
StandardCopyOption.COPY_ATTRIBUTES,
StandardCopyOption.REPLACE_EXISTING
)
()
}
assertIsFile(lastClassesDir.resolve(classFileName))
val fileName = classFileName.stripSuffix(".class")
val sjsirFile = lastClassesDir.resolve(RelativePath(s"${fileName}.sjsir"))
val externalSjsirFile = clientDir.resolve(RelativePath(s"${fileName}.sjsir"))
writeFile(sjsirFile, "emulating sjsir file")
copy(sjsirFile, externalSjsirFile)
val nirFile = lastClassesDir.resolve(RelativePath(s"${fileName}.nir"))
val externalNirFile = clientDir.resolve(RelativePath(s"${fileName}.nir"))
writeFile(nirFile, "emulating nir file")
copy(nirFile, externalNirFile)
val tastyFile = lastClassesDir.resolve(RelativePath(s"${fileName}.tasty"))
val externalTastyFile = clientDir.resolve(RelativePath(s"${fileName}.tasty"))
writeFile(tastyFile, "emulating tasty file")
copy(tastyFile, externalTastyFile)
()
}
val clientDirA = compiledState.getClientExternalDir(`A`)
val lastClassesDirA = compiledState.getLastClassesDir(`A`).get
createFakeCompileProducts(lastClassesDirA, clientDirA, "Foo.class")
createFakeCompileProducts(lastClassesDirA, clientDirA, "Bar.class")
// #2: Compiler after renaming `Foo` to `Foo2`, which should make `Bar` fail in second cycle
assertIsFile(writeFile(`A`.srcFor("Foo.scala"), Sources.`Foo2.scala`))
val secondCompiledState = compiledState.compile(`A`)
assertExitStatus(secondCompiledState, ExitStatus.CompilationError)
assertInvalidCompilationState(
secondCompiledState,
List(`A`),
existsAnalysisFile = true,
hasPreviousSuccessful = true,
hasSameContentsInClassesDir = true
)
val targetBar = TestUtil.universalPath("a/src/Bar.scala")
assertNoDiff(
s"""
|[E2] ${targetBar}:2:22
| not found: type Foo
| L2: val foo: Foo = new Foo
| ^
|[E1] ${targetBar}:2:12
| not found: type Foo
| L2: val foo: Foo = new Foo
| ^
|${targetBar}: L2 [E1], L2 [E2]
""".stripMargin,
logger.renderErrors(exceptContaining = "Failed to compile")
)
assertIsFile(writeFile(`A`.srcFor("Bar.scala"), Sources.`Bar2.scala`))
val thirdCompiledState = secondCompiledState.compile(`A`)
assertExitStatus(thirdCompiledState, ExitStatus.Ok)
assertValidCompilationState(thirdCompiledState, projects)
assertDifferentExternalClassesDirs(thirdCompiledState, compiledStateBackup, projects)
// Checks that we remove `Foo.class` from the external classes dir which is critical
assertNonExistingCompileProduct(thirdCompiledState, `A`, RelativePath("Foo.class"))
assertNonExistingCompileProduct(thirdCompiledState, `A`, RelativePath("Foo.sjsir"))
assertNonExistingCompileProduct(thirdCompiledState, `A`, RelativePath("Foo.nir"))
assertNonExistingCompileProduct(thirdCompiledState, `A`, RelativePath("Foo.tasty"))
assertNonExistingInternalClassesDir(thirdCompiledState)(compiledState, projects)
}
}
test("detect binary changes in Java within the same project") {
def compileTestWithOrder(order: Config.CompileOrder): Unit = {
TestUtil.withinWorkspace { workspace =>
object Sources {
val `Foo.java` =
"""/Foo.java
|public class Foo {
| public String greeting() {
| return "Hello World";
| }
|}
""".stripMargin
val `Bar.scala` =
"""/Bar.scala
|class Bar {
| val foo: Foo = new Foo
| println(foo.greeting())
|}
""".stripMargin
val `Foo2.java` =
"""/Foo.java
|public class Foo {
| public String hello() {
| return "Hello World";
| }
|}
""".stripMargin
val `Bar2.scala` =
"""/Bar.scala
|class Bar {
| val foo: Foo = new Foo
| println(foo.hello())
|}
""".stripMargin
}
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(
workspace,
"a",
List(Sources.`Foo.java`, Sources.`Bar.scala`),
order = order
)
val projects = List(`A`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`A`)
val compiledStateBackup = compiledState.backup
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, projects)
// #2: Compiler after changing public API of `Foo`, which should make `Bar` fail
assertIsFile(writeFile(`A`.srcFor("Foo.java"), Sources.`Foo2.java`))
val secondCompiledState = compiledState.compile(`A`)
assertExitStatus(secondCompiledState, ExitStatus.CompilationError)
assertInvalidCompilationState(
secondCompiledState,
List(`A`),
existsAnalysisFile = true,
hasPreviousSuccessful = true,
hasSameContentsInClassesDir = true
)
val targetBar = TestUtil.universalPath("a/src/Bar.scala")
assertNoDiff(
logger.renderErrors(exceptContaining = "Failed to compile"),
s"""|[E1] ${targetBar}:3:15
| value greeting is not a member of Foo
| L3: println(foo.greeting())
| ^
|${targetBar}: L3 [E1]
|""".stripMargin
)
assertIsFile(writeFile(`A`.srcFor("/Bar.scala"), Sources.`Bar2.scala`))
val thirdCompiledState = secondCompiledState.compile(`A`)
assertExitStatus(thirdCompiledState, ExitStatus.Ok)
assertValidCompilationState(thirdCompiledState, projects)
assertDifferentExternalClassesDirs(thirdCompiledState, compiledStateBackup, projects)
assertExistingCompileProduct(secondCompiledState, `A`, RelativePath("Foo.class"))
}
}
compileTestWithOrder(Config.Mixed)
compileTestWithOrder(Config.JavaThenScala)
}
test("invalidate Scala class files in javac forked and local compilation") {
TestUtil.withinWorkspace { workspace =>
object Sources {
val `Foo.java` =
"""/Foo.java
|public class Foo {
| public String printHelloWorld() {
| Bar bar = new Bar();
| return bar.greeting();
| }
|}
""".stripMargin
val `Bar.scala` =
"""/Bar.scala
|class Bar {
| def greeting(): String = "Hello World"
|}
""".stripMargin
val `Bar2.scala` =
"""/Bar.scala
|class Bar2 {
| def bla(): String = "Hello World"
|}
""".stripMargin
}
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(
workspace,
"a",
List(Sources.`Foo.java`, Sources.`Bar.scala`),
order = Config.ScalaThenJava
)
val projects = List(`A`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`A`)
assertExitStatus(compiledState, ExitStatus.Ok)
assertValidCompilationState(compiledState, projects)
assertIsFile(writeFile(`A`.srcFor("Bar.scala"), Sources.`Bar2.scala`))
val secondCompiledState = compiledState.compile(`A`)
assertExitStatus(secondCompiledState, ExitStatus.CompilationError)
assertInvalidCompilationState(
secondCompiledState,
List(`A`),
existsAnalysisFile = true,
hasPreviousSuccessful = true,
hasSameContentsInClassesDir = true
)
val targetFoo = TestUtil.universalPath("a/src/Foo.java")
val expectedMessage = {
val supportsLocalCompilation =
javax.tools.ToolProvider.getSystemJavaCompiler() != null
if (supportsLocalCompilation) {
s"""|[E2] ${targetFoo}:3
| cannot find symbol
| symbol: class Bar
| location: class Foo
| L3: Bar
| ^^^
|[E1] ${targetFoo}:3
| cannot find symbol
| symbol: class Bar
| location: class Foo
| L3: Bar
| ^^^
|${targetFoo}: L3 [E1], L3 [E2]
|""".stripMargin
} else {
s"""|[E1] ${targetFoo}:3
| error: cannot access Bar
|${targetFoo}: L3 [E1]
|""".stripMargin
}
}
assertNoDiff(
logger.renderErrors(exceptContaining = "Failed to compile"),
expectedMessage
)
}
}
test("don't compile after renaming a class and not its references in a dependent project") {
// Checks bloop is invalidating classes + propagating them to *transitive* dependencies
TestUtil.withinWorkspace { workspace =>
object Sources {
val `Foo.scala` =
"""/main/scala/Foo.scala
|class Foo
""".stripMargin
val `Foo2.scala` =
"""/main/scala/Foo.scala
|class Foo2
""".stripMargin
val `Baz.scala` =
"""/main/scala/Baz.scala
|class Baz
""".stripMargin
val `Single.scala` =
"""/main/scala/Single.scala
|class Single
""".stripMargin
val `Bar.scala` =
"""/main/scala/Bar.scala
|class Bar {
| val foo: Foo = new Foo
|}
""".stripMargin
val `Bar2.scala` =
"""/main/scala/Bar.scala
|class Bar {
| val foo: Foo2 = new Foo2
|}
""".stripMargin
}
val logger = new RecordingLogger(ansiCodesSupported = false)
val `A` = TestProject(workspace, "a", List(Sources.`Foo.scala`, Sources.`Baz.scala`))
val `B` = TestProject(workspace, "b", List(Sources.`Single.scala`), List(`A`))
val `C` = TestProject(workspace, "c", List(Sources.`Bar.scala`), List(`B`))
val projects = List(`A`, `B`, `C`)
val state = loadState(workspace, projects, logger)
val compiledState = state.compile(`C`)
assertValidCompilationState(compiledState, projects)
// #2: Compiler after renaming `Foo` to `Foo2`, which should make `Bar` fail in second cycle
assertIsFile(writeFile(`A`.srcFor("main/scala/Foo.scala"), Sources.`Foo2.scala`))
val secondCompiledState = compiledState.compile(`C`)
assertExitStatus(secondCompiledState, ExitStatus.CompilationError)
assertInvalidCompilationState(
secondCompiledState,
List(`A`, `B`, `C`),
existsAnalysisFile = true,
hasPreviousSuccessful = true,
hasSameContentsInClassesDir = true
)
val targetBar = TestUtil.universalPath("c/src/main/scala/Bar.scala")
assertNoDiff(
s"""
|[E2] ${targetBar}:2:22
| not found: type Foo
| L2: val foo: Foo = new Foo
| ^
|[E1] ${targetBar}:2:12
| not found: type Foo
| L2: val foo: Foo = new Foo
| ^
|${targetBar}: L2 [E1], L2 [E2]
""".stripMargin,
logger.renderErrors(exceptContaining = "Failed to compile")
)
assertIsFile(writeFile(`C`.srcFor("main/scala/Bar.scala"), Sources.`Bar2.scala`))
val thirdCompiledState = secondCompiledState.compile(`C`)
assertExitStatus(thirdCompiledState, ExitStatus.Ok)
// Checks that we remove `Foo.class` from the external classes dir which is critical
assertValidCompilationState(thirdCompiledState, projects)
assertNonExistingCompileProduct(thirdCompiledState, `A`, RelativePath("Foo.class"))
}
}
test("compile after moving class from one project to a dependent one") {
// Checks bloop is invalidating classes + propagating them to *transitive* dependencies
TestUtil.withinWorkspace { workspace =>
object Sources {
val `Dummy.scala` =
"""/Dummy.scala
|class Dummy
""".stripMargin
val `Foo.scala` =
"""/Foo.scala
|class Foo {
| def foo: String = ""
|}
""".stripMargin
val `Bar.scala` =
"""/Bar.scala
|class Bar extends Foo
""".stripMargin
val `Baz.scala` =
"""/Baz.scala
|class Baz {
| val bar: Bar = new Bar
| def hello = println(bar.foo)
|}
""".stripMargin
val `Dummy1.scala` =
"""/Dummy1.scala
|class Dummy1
""".stripMargin
val `Dummy2.scala` =
"""/Dummy2.scala
|class Dummy2
""".stripMargin