Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle --release option #55

Merged
merged 1 commit into from Aug 1, 2023
Merged

Conversation

Arthurm1
Copy link
Contributor

You can specify the release flag in gradle using JavaCompiler#options#release=XX.

Currently the export will handle this by including both -source=XX and -target=XX in the javac args.

With this PR, if the build specifies release then --release=XX is used. If the build specifies target or source then they are still used.

Reflection used because release was only added to Gradle in version 6.6

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit b613640 into scalacenter:main Aug 1, 2023
3 checks passed
@Arthurm1 Arthurm1 deleted the release_option branch September 21, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants