Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Use existing file system when available and don't close it #704

Merged
merged 1 commit into from
May 8, 2024

Conversation

kasiaMarek
Copy link
Contributor

connected to: scalameta/metals#5928
We want to start scala debug adapter from Metals for build servers that don't support it. In Metals FileSystems for jars are created and kept open to be reused.

@adpi2
Copy link
Member

adpi2 commented May 7, 2024

The failing tests on macOS-latest are flaky tests, you don't need to fix them.

@kasiaMarek kasiaMarek marked this pull request as ready for review May 7, 2024 13:14
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@adpi2 adpi2 merged commit 826a86f into scalacenter:main May 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants