Update scalameta, semanticdb-scalac-core, ... to 4.4.35 #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
update/scalameta-4.4.35
branch
from
3892dde
to
1d76f91
Compare
bjaglin
reviewed
Feb 15, 2022
| @@ -293,7 +293,7 @@ class CliSyntacticSuite extends BaseCliSuite { | |||
| outputAssert = { out => | |||
| assert( | |||
| out.endsWith( | |||
| """|a.scala:1:1: error: expected class or object definition identifier | |||
| """|a.scala:1:1: error: illegal start of definition identifier | |||
There was a problem hiding this comment.
this looks like a cosmetic regression caused by the Ammonite parsing changes https://github.com/scalameta/scalameta/releases/tag/v4.4.35 cc @kitbellew
There was a problem hiding this comment.
By "Ammonite parsing changes", I meant the parser refactoring changes listed to better support Ammonite parsing. Anyway, the error message is still actionable, so I didn't feel like opening an issue to track the "regression" was required.
There was a problem hiding this comment.
most likely, the change that affected this was in 4.4.34, entitled "ScalametaParser: Make allowToplevelTerms accept package declarations scalameta/scalameta#2565". ammonite changes were in 4.4.35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
from 4.4.33 to 4.4.35.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Ignore future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1