Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.eclipse.jgit to 5.13.1.202206130422-r #1637

Conversation

scala-steward
Copy link
Contributor

Updates org.eclipse.jgit:org.eclipse.jgit from 5.13.0.202109080827-r to 5.13.1.202206130422-r.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.eclipse.jgit", artifactId = "org.eclipse.jgit" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.eclipse.jgit", artifactId = "org.eclipse.jgit" }
}]

labels: library-update, commit-count:1

@bjaglin
Copy link
Collaborator

bjaglin commented Jul 16, 2022

 [error] Incompatibilities with dependencies of scalafix-cli:0.10.1
[error]   org.eclipse.jgit:org.eclipse.jgit: incompatible version change from 5.13.0.202109080827-r to 5.13.1.202206130422-r (compatibility: early semantic versioning)

looks like a false positive due to the weird scheme, we should ignore that artifact for sbt-version-policy (and report the bug?)

@bjaglin
Copy link
Collaborator

bjaglin commented Jul 22, 2022

EarlySemVer is the default for java packages in sbt-version-policy

➜  scalafix git:(update/org.eclipse.jgit-5.13.1.202206130422-r) amm
Loading...
Welcome to the Ammonite Repl 2.5.2 (Scala 2.13.8 Java 11.0.15)
@ import $ivy.`io.get-coursier::versions:0.3.1` 
import $ivy.$                                

@ coursier.version.VersionCompatibility.EarlySemVer.isCompatible("5.13.0.202109080827-r", "5.13.1.202206130422-r") 
res1: Boolean = false

@ coursier.version.VersionCompatibility.EarlySemVer.isCompatible("5.13.0.202109080827", "5.13.1.202206130422") 
res2: Boolean = true

The culprit is the trailing -r. I am not sure we have a case for opening a ticket in coursier-versions, so I'll just ignore this library (currently stuck to 5.x anyway) in the compatibility check.

@bjaglin bjaglin force-pushed the update/org.eclipse.jgit-5.13.1.202206130422-r branch from cba5a7f to ed2c3ee Compare July 22, 2022 18:52
@bjaglin bjaglin force-pushed the update/org.eclipse.jgit-5.13.1.202206130422-r branch from ed2c3ee to 4ca3349 Compare July 22, 2022 18:54
@bjaglin bjaglin merged commit e11610f into scalacenter:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants