fix UnusedScalafixSuppression warnings on Scala 3 scalafix invocations #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
Apr 21, 2024
| throw new UnsupportedOperationException( | ||
| "No longer supported." | ||
| ) // scalafix:ok | ||
| override def syntax: String = |
There was a problem hiding this comment.
for some reason, the annotation was removed in 96e3c60#diff-8bcb1fea5512e923315adba5f40c197a178dda1697225f8c955bce1db2f0a2f4
bjaglin
changed the title
Since ExplicitResultTypes is unavailable in Scala 3, some silencers are rightfully detected as unused for that invocation. Qualifying these silencers by suffixing ExplicitResultTypes does not help, since EscapeHatch is not aware of which rules are executed, so we need to address the problem differently. - For the (v0) signature, this removes the silencer to be explicit about the type since there is no reason (except compatibility) to keep it this way. Since this is the old API and a very specific class, it's unlikely that will will cause linking errors when running community rules with existing versions. - For test suites where we DO want an explicit type, this turns private the terms that ExplicitResultTypes warns on to stop triggering it. However, this triggers RemoveUnused, but since it is now common to both Scala 2 and Scala 3 and, it does not trigger UnusedScalafixSuppression in any invocation.
bjaglin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.