Read ExplicitResultTypes key instead of explicitReturnTypes #354
Conversation
| @@ -33,7 +33,7 @@ case class ExplicitResultTypes( | |||
| this(index, ExplicitResultTypesConfig.default) | |||
| override def init(config: Conf): Configured[Rule] = | |||
| config | |||
| .getOrElse("explicitReturnTypes")(ExplicitResultTypesConfig.default) | |||
| .getOrElse("explicitResultTypes")(ExplicitResultTypesConfig.default) | |||
There was a problem hiding this comment.
This will break people's existing configuration, I think we will have to support both names throughout 0.5.x. We currently have no means to emit a deprecation warning here, so no worries about that.
There's no high-level api on Conf to fallback on a different key, but a simple workaround is to check if the resulting setting is still default and then try the fallback name.
There was a problem hiding this comment.
Oh, and one more comment, see https://github.com/scalacenter/scalafix/pull/355/files#r139296465 what do you think about making it "ExplicitResultTypes" with capital E in the beginning?
There was a problem hiding this comment.
@olafurpg cool! I just pushed a new commit. To support the deprecated config I've used extraNames in Config#getOrElse. Let me know if there is something else that could be improved.
insdami
force-pushed
the
rename-cfg-explicit-return-type
branch
from
f92c5b4
to
e5216b6
Compare
olafurpg
changed the title
Small contribution from Dublin Scala Spree on #335