Simplifify api for import patches #48
Conversation
| @@ -0,0 +1,23 @@ | |||
| // Small worksheet to demonstrate usage of import patches | |||
There was a problem hiding this comment.
@ShaneDelmore I got this working on my laptop
olafurpg
force-pushed
the
intellij-buidl
branch
from
3186a96
to
fd40924
Compare
| object RewriteCtx { | ||
| def fromCode(ast: Tree, | ||
| config: ScalafixConfig = ScalafixConfig(), | ||
| semanticApi: Option[SemanticApi] = None): RewriteCtx = { |
There was a problem hiding this comment.
What happens if no SemanticApi is supplied? Is a new one created, or is functionality diminished in some way?
There was a problem hiding this comment.
Good question. It depends on what rewrite is used, some rewrites like procedure syntax work 100% without the semantic api, organize imports works without it but can't handle relative imports in that case, explicit implicit will error.
I guess this could be better documented.
| val tokenToEdit = | ||
| oldImports.headOption | ||
| .map(_.tokens.head) | ||
| .getOrElse(tokens.head) | ||
| .getOrElse(ctx.tokens.head) |
There was a problem hiding this comment.
Do we know ctx.tokens is non-empty here?
There was a problem hiding this comment.
The tree nodes that return empty tokens are incredibly few (if any) and I would say it was a truly exceptional case if those were passed in here. Top level trees always have a beginning of file token.
There's an interesting ongoing discussion in scalameta about validating trees for a given dialect. I would be interested to start a similar discussion about the possibility to use a non empty list type Where applicable. The challenge is try and encode as much as possible on the type level without burdening syntax too heavily. Quasi quotes help a lot here.
No description provided.