Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup. #9

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Cleanup. #9

merged 1 commit into from
Sep 26, 2016

Conversation

olafurpg
Copy link
Contributor

  • Replace flaky stringbuilder with Patch.
  • Reuse Cli in sbt plugin.
  • Replace Fixed with Either[Throwable, String]
  • Move all configuration to ScalafixConfig
  • Pass RewriteCtx to all rewrite rules
  • Run all rewrites on same tree.

- Replace flaky stringbuilder with Patch.
- Reuse Cli in sbt plugin.
- Replace Fixed with Either[Throwable, String]
- Move all configuration to ScalafixConfig
- Pass RewriteCtx to all rewrite rules
- Run all rewrites on same tree.
@olafurpg olafurpg merged commit b3e8d2b into master Sep 26, 2016
@olafurpg olafurpg deleted the patch3 branch September 26, 2016 12:04
stephenjudkins pushed a commit to stephenjudkins/scalafix that referenced this pull request Jan 16, 2019
rvacaru added a commit to rvacaru/scalafix that referenced this pull request Oct 1, 2022
This is the commit message scalacenter#2:

WIP unit3 to show code, not working
unit3 munit dep: exclude 2.13 and include munit_3 instead

WIP unit3 fixed some unit3 compilation errors, many  errors, all similar, on unit2* to fix

This is the commit message scalacenter#2:

fixed compilation error unit SaveExpect class ()

unit2Target2 fix with scalatest version to 3.2.0, but this shouldn't be bumped as per comment(breaking clients via eviction)

fix unit2Target2 by reintroducing scalatest 3.2.0 in unit libs for scala2 versions

unit3 fix Test/compilation errors

unit3 test RuleDecoderSuite: removed scalafix.v1.Rule rules not available in scala3: explicitResultTypes and ProcedureSintax

unit3 moved test ScalafixArgumentsSuite to scala-2, cause it depends on semanticdb-scalac_3.1.3

unit3 changed CliGitDiffSuite.'works on Patch' to not use ProcedureSyntaxRule cause not available for scala3

Revert "unit3 moved test ScalafixArgumentsSuite to scala-2, cause it depends on semanticdb-scalac_3.1.3"

This reverts commit 7bad87b.

unit3 ScalafixArgumentSuite compat/semanticdb split, version 2 pr comments applied

unit3 unmanagedresources folders for cross compilation, scalafmt and scalafixAll applied

unit3 introduced CompatSemanticdb for scala3 with semanticdb new options, fixed one unit test

 This is the commit message scalacenter#2:

unit 3 PrettyExpectSuite split expected results between scala2 and 3

 This is the commit message scalacenter#3:

unit 3 Apply suggestions from code review, small changes to build and rules

Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
 This is the commit message scalacenter#4:

change scalatest dep and refactored jgit

 This is the commit message scalacenter#5:

fix windows ci scaladoc issue on paths: upgrade scala3 to 3.2.0

 This is the commit message scalacenter#6:

unit3 test rulecompiler

 This is the commit message scalacenter#7:

unit3 ToolClasspathSuite changed dependency to scalatest and renamings

 This is the commit message scalacenter#8:

unit3 ScalafixArgumentsSuite and classes to provide compiler options

 This is the commit message scalacenter#9:

unit3 scalafmt and scalafixAll
rvacaru added a commit to rvacaru/scalafix that referenced this pull request Oct 1, 2022
This is the commit message scalacenter#2:

WIP unit3 to show code, not working
unit3 munit dep: exclude 2.13 and include munit_3 instead

WIP unit3 fixed some unit3 compilation errors, many  errors, all similar, on unit2* to fix

This is the commit message scalacenter#2:

fixed compilation error unit SaveExpect class ()

unit2Target2 fix with scalatest version to 3.2.0, but this shouldn't be bumped as per comment(breaking clients via eviction)

fix unit2Target2 by reintroducing scalatest 3.2.0 in unit libs for scala2 versions

unit3 fix Test/compilation errors

unit3 test RuleDecoderSuite: removed scalafix.v1.Rule rules not available in scala3: explicitResultTypes and ProcedureSintax

unit3 moved test ScalafixArgumentsSuite to scala-2, cause it depends on semanticdb-scalac_3.1.3

unit3 changed CliGitDiffSuite.'works on Patch' to not use ProcedureSyntaxRule cause not available for scala3

Revert "unit3 moved test ScalafixArgumentsSuite to scala-2, cause it depends on semanticdb-scalac_3.1.3"

This reverts commit 7bad87b.

unit3 ScalafixArgumentSuite compat/semanticdb split, version 2 pr comments applied

unit3 unmanagedresources folders for cross compilation, scalafmt and scalafixAll applied

unit3 introduced CompatSemanticdb for scala3 with semanticdb new options, fixed one unit test

 This is the commit message scalacenter#2:

unit 3 PrettyExpectSuite split expected results between scala2 and 3

 This is the commit message scalacenter#3:

unit 3 Apply suggestions from code review, small changes to build and rules

Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
 This is the commit message scalacenter#4:

change scalatest dep and refactored jgit

 This is the commit message scalacenter#5:

fix windows ci scaladoc issue on paths: upgrade scala3 to 3.2.0

 This is the commit message scalacenter#6:

unit3 test rulecompiler

 This is the commit message scalacenter#7:

unit3 ToolClasspathSuite changed dependency to scalatest and renamings

 This is the commit message scalacenter#8:

unit3 ScalafixArgumentsSuite and classes to provide compiler options

 This is the commit message scalacenter#9:

unit3 scalafmt and scalafixAll

unit3 to be rebased
bjaglin pushed a commit to rvacaru/scalafix that referenced this pull request Oct 2, 2022
This is the commit message scalacenter#2:

WIP unit3 to show code, not working
unit3 munit dep: exclude 2.13 and include munit_3 instead

WIP unit3 fixed some unit3 compilation errors, many  errors, all similar, on unit2* to fix

This is the commit message scalacenter#2:

fixed compilation error unit SaveExpect class ()

unit2Target2 fix with scalatest version to 3.2.0, but this shouldn't be bumped as per comment(breaking clients via eviction)

fix unit2Target2 by reintroducing scalatest 3.2.0 in unit libs for scala2 versions

unit3 fix Test/compilation errors

unit3 test RuleDecoderSuite: removed scalafix.v1.Rule rules not available in scala3: explicitResultTypes and ProcedureSintax

unit3 moved test ScalafixArgumentsSuite to scala-2, cause it depends on semanticdb-scalac_3.1.3

unit3 changed CliGitDiffSuite.'works on Patch' to not use ProcedureSyntaxRule cause not available for scala3

Revert "unit3 moved test ScalafixArgumentsSuite to scala-2, cause it depends on semanticdb-scalac_3.1.3"

This reverts commit 7bad87b.

unit3 ScalafixArgumentSuite compat/semanticdb split, version 2 pr comments applied

unit3 unmanagedresources folders for cross compilation, scalafmt and scalafixAll applied

unit3 introduced CompatSemanticdb for scala3 with semanticdb new options, fixed one unit test

 This is the commit message scalacenter#2:

unit 3 PrettyExpectSuite split expected results between scala2 and 3

 This is the commit message scalacenter#3:

unit 3 Apply suggestions from code review, small changes to build and rules

Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
 This is the commit message scalacenter#4:

change scalatest dep and refactored jgit

 This is the commit message scalacenter#5:

fix windows ci scaladoc issue on paths: upgrade scala3 to 3.2.0

 This is the commit message scalacenter#6:

unit3 test rulecompiler

 This is the commit message scalacenter#7:

unit3 ToolClasspathSuite changed dependency to scalatest and renamings

 This is the commit message scalacenter#8:

unit3 ScalafixArgumentsSuite and classes to provide compiler options

 This is the commit message scalacenter#9:

unit3 scalafmt and scalafixAll

unit3 to be rebased
bjaglin pushed a commit to rvacaru/scalafix that referenced this pull request Oct 10, 2022
This is the commit message scalacenter#2:

WIP unit3 to show code, not working
unit3 munit dep: exclude 2.13 and include munit_3 instead

WIP unit3 fixed some unit3 compilation errors, many  errors, all similar, on unit2* to fix

This is the commit message scalacenter#2:

fixed compilation error unit SaveExpect class ()

unit2Target2 fix with scalatest version to 3.2.0, but this shouldn't be bumped as per comment(breaking clients via eviction)

fix unit2Target2 by reintroducing scalatest 3.2.0 in unit libs for scala2 versions

unit3 fix Test/compilation errors

unit3 test RuleDecoderSuite: removed scalafix.v1.Rule rules not available in scala3: explicitResultTypes and ProcedureSintax

unit3 moved test ScalafixArgumentsSuite to scala-2, cause it depends on semanticdb-scalac_3.1.3

unit3 changed CliGitDiffSuite.'works on Patch' to not use ProcedureSyntaxRule cause not available for scala3

Revert "unit3 moved test ScalafixArgumentsSuite to scala-2, cause it depends on semanticdb-scalac_3.1.3"

This reverts commit 7bad87b.

unit3 ScalafixArgumentSuite compat/semanticdb split, version 2 pr comments applied

unit3 unmanagedresources folders for cross compilation, scalafmt and scalafixAll applied

unit3 introduced CompatSemanticdb for scala3 with semanticdb new options, fixed one unit test

 This is the commit message scalacenter#2:

unit 3 PrettyExpectSuite split expected results between scala2 and 3

 This is the commit message scalacenter#3:

unit 3 Apply suggestions from code review, small changes to build and rules

Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
 This is the commit message scalacenter#4:

change scalatest dep and refactored jgit

 This is the commit message scalacenter#5:

fix windows ci scaladoc issue on paths: upgrade scala3 to 3.2.0

 This is the commit message scalacenter#6:

unit3 test rulecompiler

 This is the commit message scalacenter#7:

unit3 ToolClasspathSuite changed dependency to scalatest and renamings

 This is the commit message scalacenter#8:

unit3 ScalafixArgumentsSuite and classes to provide compiler options

 This is the commit message scalacenter#9:

unit3 scalafmt and scalafixAll

unit3 to be rebased
bjaglin pushed a commit to liancheng/scalafix that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant