Fix #93 #94
Fix #93 #94
Conversation
New settings: - webpackMonitoredDirectories - webpackMonitoredIncludeFilter New task: - webpackMonitoredFiles
|
Can one of the admins verify this patch? |
|
test this please |
|
Refer to this link for build results (access rights to CI server needed): |
| * @see [[webpackMonitoredDirectories]] | ||
| */ | ||
| val webpackMonitoredIncludeFilter: SettingKey[FileFilter] = | ||
| settingKey[FileFilter]("Filter for files, monitored for webpack launch") |
There was a problem hiding this comment.
Why not reuse the existing includeFilter key, scoped to the webpackMonitoredFiles task?
There was a problem hiding this comment.
You're right, of course. Scoped includeFilter is more idiomatic. Will change this shortly.
| generatedWebpackConfigFile +: | ||
| customWebpackConfigFile ++: | ||
| entries.map(_._2) ++: | ||
| additionalFiles |
There was a problem hiding this comment.
I think you should also add stageTask.value.data, which contains the .js code produced by Scala.js (the entries contain only the launcher files, which depend on them). I don’t know how we could automate the resolution of the dependencies among .js files…
There was a problem hiding this comment.
Will do. I seem to have lost this one in the transition.
|
Awesome, thanks! |
Implements changes proposed in #93:
scalaJSBundlerPackageJsoncaching behavior.webpacktask caching settings.I had to use a slightly more involved API for monitored files (
webpackMonitoredDirectoriesandwebpackMonitoredIncludeFiltersettings,webpackMonitoredFilestask). A single file list setting is not flexible enough, and a file list task that is supposed to be overridden is overkill in most cases.Fixes #93