NPE in TableColumn.cellValueFactory_=

[s-bernard]

In:

scalafx/scalafx/src/main/scala/scalafx/scene/control/TableColumn.scala

Line 320 in e9cb926

f(v).delegate

if f(v) return null, we get a NPE. However, it is a totally acceptable value for javafx to return null here.

Suggested fix, replace line 320 by Option(f(v)).map(_.delegate).getOrElse(null).

Maybe a future solution would be to change f to be f: TableColumn.CellDataFeatures[S, T] => Option[ObservableValue[T, T]] to limit the number of Option wrapping as discussed in #370.

[jpsacha]

@s-bernard can you create a PR with the suggested fix?
Option(f(v)).map(_.delegate).getOrElse(null)

Looks that this needs to be done for TableColumn and TreeTableColumn

Let's keep the signature for f as it is for now

[s-bernard]

Yes, OK